Skip to content

fix(shared-helpers): spell out SRO/BR unit type acronyms in core locale copy#6315

Draft
Copilot wants to merge 5 commits into
mainfrom
copilot/spell-out-sro-and-br
Draft

fix(shared-helpers): spell out SRO/BR unit type acronyms in core locale copy#6315
Copilot wants to merge 5 commits into
mainfrom
copilot/spell-out-sro-and-br

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

This PR addresses #(insert-number-here)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This update applies the acronym-expansion change in core (shared translations) instead of public-only overrides, per review feedback.

  • Updated shared English locale strings in shared-helpers/src/locales/general.json:
    • listings.singleRoomOccupancySingle Room Occupancy
    • listings.unitTypes.SROSingle Room Occupancy
    • listings.unitTypes.oneBdrm1 Bedroom
    • listings.unitTypes.twoBdrm2 Bedrooms
    • listings.unitTypes.threeBdrm3 Bedrooms
    • listings.unitTypes.fourBdrm4 Bedrooms
    • listings.unitTypes.fiveBdrm5 Bedrooms
  • Reverted the public override additions in sites/public/page_content/locale_overrides/general.json.
  • Removed the added test file sites/public/__tests__/lib/translations.test.ts (redundant coverage).
  • Updated existing assertions in sites/public/__tests__/components/browse/FilterDrawer.test.tsx to match Single Room Occupancy.

How Can This Be Tested/Reviewed?

  1. Confirm the updated strings in shared-helpers/src/locales/general.json for listings.singleRoomOccupancy and listings.unitTypes.*.
  2. Confirm sites/public/page_content/locale_overrides/general.json no longer contains the added unit-type overrides from the earlier revision.
  3. Review sites/public/__tests__/components/browse/FilterDrawer.test.tsx for updated expected label text.
  4. Run targeted tests:
    • cd /home/runner/work/bloom/bloom/sites/public && yarn test:unit --watchAll=false __tests__/components/browse/FilterDrawer.test.tsx __tests__/components/listing/ListingView.test.tsx
  5. Run lint:
    • cd /home/runner/work/bloom/bloom && yarn lint
  6. Manual verification: run public app and verify unit-type copy renders expanded wording (screenshot captured during verification).

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 90e2249
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a1df6d48c40b70008ec8f57
😎 Deploy Preview https://deploy-preview-6315--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for partners-bloom-msq2 canceled.

Name Link
🔨 Latest commit 9f94175
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/6a0b4d5da3f1920008dfa6f5

Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/caf977dc-a917-4a67-ba23-160c10934d7d

Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Copilot AI changed the title [WIP] Spell out SRO and unit type abbreviations on public site fix(public): spell out SRO/BR unit type acronyms in public copy May 15, 2026
Copilot AI requested a review from emilyjablonski May 15, 2026 19:12
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 90e2249
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a1df6d48027b50008994ed8
😎 Deploy Preview https://deploy-preview-6315--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 90e2249
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6a1df6d4164bee0008c6a9ff
😎 Deploy Preview https://deploy-preview-6315--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 90e2249
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a1df6d491e2bb000821754d
😎 Deploy Preview https://deploy-preview-6315--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're able to do this in core, which means to make the changes in the general file in shared-helpers. We can also remove the new test - it's not testing anything we don't have covered elsewhere.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 18, 2026

We're able to do this in core, which means to make the changes in the general file in shared-helpers. We can also remove the new test - it's not testing anything we don't have covered elsewhere.

Updated in commit 9f94175: moved the wording changes into shared-helpers/src/locales/general.json, reverted the public override file, removed the added sites/public/__tests__/lib/translations.test.ts, and updated existing FilterDrawer expectations accordingly. Screenshot from manual verification: /tmp/public-listings-core-acronyms.png.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • android.clients.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clientservices.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • fonts.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • optimizationguide-pa.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • update.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6170 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.MScjNT --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2894174411893712979,2386625631924478223,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9055630256509346843,11307506862588716212,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/tmp/public-listings-core-acronyms.png --window-size=1440,1024 http://localhost:3000/listings ndor/bin/git (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6356 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.sJbKbr --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9662124638124424091,1503776753650716441,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12600886363901574933,12928346593841292784,4 --trace-process-track-uuid=3190708989122997041 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title fix(public): spell out SRO/BR unit type acronyms in public copy fix(shared-helpers): spell out SRO/BR unit type acronyms in core locale copy May 18, 2026
Copilot AI requested a review from emilyjablonski May 18, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spell out "SRO" on public site

2 participants